PEP8 - Enigma2

Hi,

As proposed by @Taapat, there is pep8 style guide checker in debian called pep8 (http://pypi.python.org/pypi/pep8).

Here are the style issues that Enigma2 currently has...
 

53154   W191 indentation contains tabs
4854    E251 unexpected spaces around keyword / parameter equals
4816    E501 line too long (82 > 79 characters)
1021    E231 missing whitespace after ','
894     E302 expected 2 blank lines, found 1
581     E201 whitespace after '{'
574     E128 continuation line under-indented for visual indent
488     E261 at least two spaces before inline comment
442     E202 whitespace before '}'
349     E265 block comment should start with '# '
341     E203 whitespace before ':'
320     E122 continuation line missing indentation or outdented
299     E502 the backslash is redundant between brackets
243     E225 missing whitespace around operator
220     E301 expected 1 blank line, found 0
179     W601 .has_key() is deprecated, use 'in'
164     E101 indentation contains mixed spaces and tabs
128     E262 inline comment should start with '# '
109     E703 statement ends with a semicolon
90      E712 comparison to True should be 'if cond is True:' or 'if cond:'
69      E126 continuation line over-indented for hanging indent
63      E227 missing whitespace around bitwise or shift operator
62      E228 missing whitespace around modulo operator
42      E713 test for membership should be 'not in'
35      E711 comparison to None should be 'if cond is not None:'
34      W391 blank line at end of file
29      E222 multiple spaces after operator
29      E221 multiple spaces before operator
29      E112 expected an indented block
26      W291 trailing whitespace
24      E303 too many blank lines (2)
21      W292 no newline at end of file
21      E701 multiple statements on one line (colon)
17      E127 continuation line over-indented for visual indent
15      E211 whitespace before '['
12      E714 test for object identity should be 'is not'
11      E224 tab after operator
10      W602 deprecated form of raising exception
9       E401 multiple imports on one line
8       E272 multiple spaces before keyword
8       E113 unexpected indentation
7       E271 multiple spaces after keyword
3       W604 backticks are deprecated, use 'repr()'
2       W293 blank line contains whitespace
2       E273 tab after keyword
2       E121 continuation line under-indented for hanging indent
1       E702 multiple statements on one line (semicolon)
1       E223 tab before operator
1       E131 continuation line unaligned for hanging indent
1       E124 closing bracket does not match visual indentation

Of course just changing the tabs to spaces is really big change and will rewrite all code.

So lets forget issue W191

For those who like to pick an issue and send an update there is an easy way. On debian install python-autopep8 (https://pypi.python.org/pypi/autopep8/)

Then run this against enigma2 repository...

Example follows for W601.
 

find -type f -name "*.py" | xargs autopep8 -ia --select=W601

Here are the results: https://github.com/athoik/enigma2/commit/5b24232e53346534df011dbb3c1be2f95c2c1c7a

Review the changes and commit this using Github pull request